https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729

--- Comment #51 from Thomas Klausner <[email protected]> ---
I think we should NOT apply any of these patches:

Hot reload is only needed during dev, and it's much easier to (manually) start
koha-plack in a non-demaonized way with hot-reload in Koha-Testing-Docker, than
to modify this (IMO slightly crazy) script to start Koha in production.

This way we won't cause any problems with prod (where hot-reload should never
be active anyway).

It's a tiny bit annoying that one first has to start ktd, enter the container,
stop the daemonzied version, and then start the hot-reload plack, but as one
only has to do this once a day (or once per hack-session..) it's acceptable
IMO.

See Comment 48

So I suggest we reject these patches and instead add either docs or a small
wrapper script to koha-testing-docker.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to