https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784
--- Comment #16 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- (In reply to Kyle M Hall from comment #11) > > Most of these are cosmetic and should be quick to follow-up: > > > > 1) Needs a follow-up to fix documentation. > > > > +=head3 populate_empty_callnumbers > > + > > +Controller function that handles deleting a biblio object > > Fixed! Yes, but introducing more wrong terminology (see 2). > > 2) Spelling > > > > In the item form and the holding table we are using 'call number', but the > > patch uses 'callnumber'. I believe we should follow the GUI. > > > > See also: https://wiki.koha-community.org/wiki/Terminology > > Fixed! Not quite, see my follow-up. > > 3) I feel we should include the call number that would be used in the > > confirmation question. > > > > if ( confirm(__('Are you sure you want to populate callnumbers for all items > > without a callnumber on this record?')) ) > > Wow, that was more work than I expected but I was able to make that happen! Sorry, but I believe it's worth it! And it works nicely too. > > 4) Please no line breaks in translatable strings! > > > > This is a known issue with Pootle, not sure about Weblate, but translators > > often might not know what it is and accidentally remove it. > > > > msg += __('\nReload the page?'); > > let msg = __('Item populated with the callnumber "%s"\nReload the > > page?').format(callnumber); You did: + msg += " " + __('Reload the page?'); You could just have done this to keep your line break: + msg += "\n" + __('Reload the page?'); We can do line breaks, they just should not be with the translated string :) > I think I've fixed this based on your description. We should add a coding > guideline for this. I thought we had one, but it might be lost in time. I fixed a ton of those strings back in the day. This one goes in the right direction, even if it uses HTML formatting: JS3: Avoid strings which mix text and markup > > 4) Button in the holdings table > > > > The button for every single item in the holdings table takes up quite a bit > > of space. I wonder if we could find a way to make this work a little better. > > Maybe a split button with Edit as the main action? > Done! Yes, but it no longer works :( POST http://localhost:8081/api/v1/biblios/undefined/items/undefined/populate_empty_callnumbers The undefined don't look good. > > > > 5) Button in the detail page's toolbar (not blocker) > > > > Why not move this into the edit menu? > > Done! Yes, but it no longer works :( POST http://localhost:8081/api/v1/biblios/undefined/items/populate_empty_callnumbers > > > > 4) Maintenance script? (not blocker) > > > > I wonder about the use case to require such a one by one change. If you have > > itemcallnumber set, this would only apply to items that have been created > > before, that have been imported or otherwise added from outside of Koha. > > > > Are there plans for a maintenance script to do this in batch? > > There are no plans for a maintenance script but I'd be happy to make one on > a followup bug report if you can provide the parameters you'd like to see! I don't need one, I was just wondering if there was more planned around this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/