https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159410|0 |1 is obsolete| | Attachment #159411|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <[email protected]> --- Created attachment 159428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159428&action=edit Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. Test Plan: 1) Check out Koha 22.05.05 2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan period set to 7, with one of the non-default rules having a Loan period of 14. 3) Delete all but one of the non-default rules with the following query: Delete from circulation_rules where rule_name = 'issuelength' and ( rule_value != 14 and not ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2; 4) Check out 254f721320 5) Run updatedatabase.pl and restart 6) Note the rules were recreated with the value 0 7) Repeat steps 1-4 8) Apply this patch 9) If you're using the same database, set the version to 22.0600023 and restart 10) Run updatedatabase.pl 11) Note the rules were recreated, but the value is the derived value from the all/all/all rule! Signed-off-by: Kevin Carnes <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Emily Lamancusa <[email protected]> Bug 33847: Rewrite to use SQL Signed-off-by: Emily Lamancusa <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> [EDIT] Squashed, and added reference to new bug too -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
