https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com, | |[email protected] | |m Status|Needs Signoff |Failed QA --- Comment #2 from Pedro Amorim <[email protected]> --- Failing QA here: 1) Not tidy 2) Leftover Data::Dumper import 3) Many empty new lines 4) This enhancement turns the script into an interactive script, requiring interactive input. This change in behavior will potentially cause existing systems running this script (as a cron or otherwise) to fail. My suggestion here is to update the code to instead allow for params instead of turning it interactive, e.g.: perl misc/maintenance/search_for_data_inconsistencies.pl --items-branch --items-status And keep functionality of running all checks by default as is currently, this ensures existing default functionality plus the new enhancement, instead of changing current default functionality. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
