https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919
--- Comment #24 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- I don't understand why you stubborn and obstinate to do things differently. I have said that 10x on bug 32607, then here again. 1. computed title instead of the logic in template 2. retrieving the client api from setup() 3. _has_value should not be needed, we have form validation already 4. you should clean the api-client, why do you deal with headers and json stringify? we don't need it in other places! 5. in the routes: BeforeUnloadEvent() { window.location.href = "/cgi-bin/koha/admin/admin-home.pl"; }, Why? 6. Why do you name the add/edit component "Edit" when all others are named "AddForm"? 7. Why calling the client api this way: .then(() => something()) when all existing occurrences do: .then( success => something(), error => {}, ); 8.Edit.vue Object.keys(response).forEach(key => { this.row[key] = response[key] }) What's the point of this?? Some are blocker, some are weirdness, others are better than what exist but different. I let you decide the status of this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/