https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #470 from David Cook <[email protected]> ---
Comment on attachment 162078
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162078
Bug 15516: Relevant controller changes and tests

Review of attachment 162078:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15516&attachment=162078)
-----------------------------------------------------------------

::: Koha/Holds.pm
@@ +213,5 @@
> +
> +sub count_holds {
> +    my ( $self, $search_params ) = @_;
> +
> +    $search_params = {

These $search_params lines redefine the variable instead of updating the
variable. This means that you end up selecting all holds and not just the holds
for particular criteria (like an individual patron).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to