https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352
--- Comment #41 from David Cook <[email protected]> --- (In reply to Martin Renvoize from comment #8) > There's an undocumented feature here: When 'autoMemberNum' is enabled > there's a second plugin hook available called 'barcode_generate'. > > I'm wondering if this needs to be an explicit method of it's own as > currently implemented or it could just be the case for when an empty or > undefined cardnumber is passed to the patron_barcode_transform hook? Apparently this was already discussed. I would've preferred a second hook for sure. I thought maybe it would be safe to create a new cardnumber when it's empty/undefined, but Koha::Patron::store() has some oddities. Like "patron_barcode_transform" gets called twice if you're using autoMemberNum... and fixup_cardnumber() assumes the output of autoMemberNum is an integer, which seems presumptuous especially when the original use case talked about prefixing/suffixing cardnumbers with letters... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
