https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120
--- Comment #72 from Martin Renvoize <[email protected]> --- (In reply to Nick Clemens from comment #60) > This works great in a lot of ways, but I found a couple issues: > 1 - We need unit tests for the pickup_locations change and the API API tests next to come, but Koha::Biblio and Koha::Booking tests are now covered > 2 - The pickup_locations for items should be set from the list for that > item, not from the entire bib so far: > for my $location (@pickup_locations) { > should be > for my $location (@{$item_pickup_locations}) { Good spot, corrected. > 5 - The pickup_library_id is defaulted to NULL - it should be NOT NULL to > match hold pickup location Resolved now Still working on comments 3 and 4 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
