https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340
--- Comment #10 from Katrin Fischer <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #9) > (In reply to Katrin Fischer from comment #8) > > IIUC this would change what we understand as a pick-up location. Currently > > we understand the pick-up location as the library the item is waiting at. > > We'd like to add the desk to this as another optional factor. > > > > > pickup_location_id (PK) > > > library_id > > > desk_id > > > description > > > public_description > > > > My feeling is that we don't need a new table here as we already have all the > > information in "desks", especially since they are already tied to a library. > > I don't feel like we need to be able to reuse desks at different libraries, > > the current implementation defining them as a "place" within a library feels > > correct and sufficient. > > We need a table in which each row represents each allowed combination. Not > all combinations are necessarily valid pickup locations. I think that's where we might misunderstand each other. Which combinations are you referring to? Library A - Desk A is a fixed combination. Library B - Desk A would be invalid. But there is a need to have desks optional, so maybe: Library A Library B - Desk A Library B - Desk B I am still confused by the need for a new table unless we completely restructure, but maybe that is the plan? Option A: * Remove the "is pick-up location" from the library configuration page (seems logical to not have multiple spots to maintain this information) * Add the new table * Possible problems: migration for existing libraries, additional setup requirements for making holds functional, possible conflicts with pickup-location related settings in circulation conditions (needs a closer look) * Possible advantages: It might be easier to implement something like "certain item types can only be picked up at certain desks" later on? Option B: * Keep checkbox "is pick-up location" on library configuration page * Add checkbox "available for pick-up" to desks * Possible problems: might limit future enhancements... (maybe I am getting there) > > I am not sure a separate description is strictly needed either - we could > > imagine 2 possible implementations in the interface: > > > > * Have 2 separate pull-downs: select the library first, then see a list of > > available desks for it. > > * Have a combined pull-down of library + desk name. > > This is overcomplicating it, actually. UI-wise it would be clearer if we > just provided a 'Pickup location' pull down. And in some cases you just > wouldn't specify a description and it will fall back to the library or > 'Library name (desk)'. OK, it might depend on the numbers of options. Adding desks could make the list significantly longer for consortia, but we can still group by library with your data model for UI if needed. > On the other hand, whenever we add endpoints for things that are not really > mapped to a table with other linked tables, we end up generating weird > controller code that is buggy and too complex :-D > > Happy to keep the discussion open, I'm not really attached to any solution. > I just think our current approach to pickup locations is too limited on the > API front. I have no idea about the API front, but it might be limiting our workflows too :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
