https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #13 from Tomás Cohen Arazi <[email protected]> --- (In reply to Jonathan Druart from comment #11) > It could work to reduce the number of lines in the -api-client.js. > > Two points however: > 1. The endpoint need to be configurable. 'this._baseURL + "/" + id' is too > simple and does not work for everything (eg. /patrons/{patron_id}/holds, > /trains/{train_id}/items/{item_id}) In my opinion, such cases should be handled, maybe with some more parameters to api-client-base. I totally get it and saw it in the code. > 2. So far we have decided to provide what is implemented/used. With this we > will offer in the view usage of routes that may not be implemented yet. Am I right to interpret what you say like: 'if the Vue page doesn't allow deleting the resource, we shouldn't implement a delete() method'? It feels to me that this shouldn't be an issue... and would allow people to reuse this more? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
