https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111
--- Comment #24 from Victor Grousset/tuxayo <[email protected]> --- (In reply to Matthias Le Gac from comment #21) > I put the test plan in the commit message I missed that there was again the 1st mistake: so indeed the patch on comment 18 didn't have the test plan and it would have been lost on Owen's signoff. So thanks for fixing this. The most reliable approach is to not use the comment function when attaching patches. Everything related to the patch itself should be in the commit message. And additional comments should be written in a separate bugzilla comment. > It's better now? What I meant in comment 19 by duplication is that when looking at the latest version of : - Bug 36111: 856$h should not appear as a link in detailed record - Bug 36111: removes display of fields 856y3z if not 856u they are 80% duplicate and it's the second one that is the complete one. So it's easy to miss. To fix this, the full test plan should be put in the 1st commit. And it should be removed from the 2nd commit. So there is only one test plan and it's complete. (there is a gotcha when doing back and forths for the 1st time with patches on bugzilla: grab the patches from bugzilla and not from your local branch before starting working on changes, to not loose the signoff that have been added here) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
