https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972
--- Comment #15 from Emily Lamancusa <[email protected]> --- Hi Marcel, thanks for taking a look! > I am just wondering how much sense it makes to still have GetOtherReserves. > Couldnt we just obsolete it here now? I agree that GetOtherReserves should be removed. I was originally planning on submitting a trivial bugfix here and doing the refactor on a follow-up bug. I ended up needing to do some of the refactoring here anyway, though, so at this point I think you're right that it makes more sense to obsolete it now. I'll work on a revised patchset. > Around the first call I am wondering what happens now if you came from the > $cancel_reserve branch of the if statement. After that you go to > GetOtherReserves. Which changed behavior and does nothing now. Did it > formerly handle the next reserve after the cancelled one? It still does identify the next reserve after the cancelled one (but it does that by calling CheckReserves, which could be called directly instead). It was *supposed to* fully handle the next reserve, i.e. set it to waiting or put it in transit, but it didn't do that properly (see comment 1). The rest are fair points; I'll address them in the new patchset as well. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
