https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36507
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] | |m --- Comment #5 from Pedro Amorim <[email protected]> --- Existing patch is good and fixes what's supposed to fix. But I think additional work is required here: When you set a desk and save, if you go back to the set desk screen, you'll notice the pre-selected value is not the one you just saved to. I believe this is caused by something wrong happening in desk_selection.js. If you apply the below changes, the issue I mention above gets fixed (but I'm unsure what it breaks - if anything): +++ b/koha-tmpl/intranet-tmpl/prog/js/desk_selection.js @@ -2,7 +2,7 @@ $(document).ready(function() { $("#desk_id").children().each(function() { var selectedBranch = $("#branch"). children("option:selected"). val(); if ($(this).attr('id') === "nodesk") { //set no desk by default, should be first element - $(this).prop("selected", true); + // $(this).prop("selected", true); $(this).prop("disabled", false); $(this).show(); } @@ -11,7 +11,7 @@ $(document).ready(function() { $('#nodesk').hide(); $(this).prop("disabled", false); $(this).show(); - $(this).prop("selected", true) + // $(this).prop("selected", true) } else { ---- FURTHER TESTING ---- Delete a desk: /cgi-bin/koha/admin/desks.pl?op=delete_confirm&desk_id=1 Confirmation screen has all blank data ---- Following the above, click confirm delete, you get: An error occurred when deleting this desk. Check the logs for details. ---- Edit an existing desk: /cgi-bin/koha/admin/desks.pl?op=add_form&desk_id=1 You're unable to change library (unsure if this is intended or not) ----- Some of the above may be considered their own separate bugs (the delete and edit(?) issues), but I feel like at least the first issue (wrong pre-selected desk) should be fixed here. Let me know if you disagree, and we can turn this to PQA and fix the others in their own bugs. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
