https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Option for cataloguing      |Option for cataloguing
                   |tools to also be shown in   |tools to also be shown in
                   |Tools Home                  |tools home
             Status|Passed QA                   |Failed QA

--- Comment #27 from Katrin Fischer <[email protected]> ---
1) General

I have to admit, I am not a fan of this one. I'll try to explain:

* The cataloguing start page was introduced in 22.11. So it's already 1.5 years
since the change when this will be released. That's a lot of time to "go back"
to previous. 

* I think there is something in UX about as soon as you have more content than
fits on a screen, things get difficult. With this patch applied I can only see
the tools preferences unless I scroll down. I wonder if the advantage of having
it in 2 places doesn't get negated by that.

* There is a style mis-match here between the old and the new which makes it
not look less attractive and inconsistent in my opinion.

* AND: This makes it appear by default on update, and I am really stuck on that
one. If you all insist on having this, I think it should be optional and not
appear on update (least change of behavior as the original change was too long
ago). If YASP is the way, then it shall be. I know CSS, but you can't set CSS
as easily on update, so I think that would be a better compromise here.

Open for discussion!

2) Unused code

-
+    <div class="row">
+        <div id="cataloging-tools-menu" class="cataloging-tools-menu toggle-ct
col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
+            [% INCLUDE 'cataloging-tools.inc' %]
+        </div>
+    </div>
+    <script>
+        $("a.toggle-ct").click(function(){
+            $(".toggle-ct").toggle();
+        });

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to