https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34902
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <[email protected]> --- Please note the static branch: # If the number of holds is not above the threshold, we can stop here if ( $holds->count() <= $decreaseLoanHighHoldsValue ) { return $return_data; } And as I read the original code, I think that it does what the pref says. # If the number of holds is less than the count of items we have # plus the number of holds allowed above that count, we can stop here - if ( $holds->count() <= $threshold ) { + if ( $holds->count() < $threshold ) { return $return_data; } So if you have 1 holdable item and pref = 1, than we should check if holds->count <= 2. In that case you do not exceed. If it is 3, than the holds count is more than 1 PLUS the number of holdable items (1) on the record. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
