https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33205
--- Comment #2 from Nick Clemens <[email protected]> --- Created attachment 164826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164826&action=edit Bug 33205: (bug 28268 follow-up) Method call $row->authid inside quotes - produces meaningless warning Bug 28268, in Koha::MetadataRecord::Authority::get_all_authorities_iterator, introduced a warning: warn "Something went wrong reading record for authority $row->authid: $@\n"; But a method cannot be called from within quotes in Perl - extrapolation does not work for functions/methods. So, if something really goes wrong, this line of code produces a warning like: Something went wrong reading record for authority Koha::Schema::Result::AuthHeader=HASH(0x55cf7e0d0958)->authid: Empty String at /usr/share/perl5/MARC/File/XML.pm line 450. which is not very informative -- authid is missing. Test plan ========= Hard to reproduce. This problem occurs only in rare cases of some weird problem in stores authority data or if a auth record had been deleted after a ES reindex action has been initiated. But the problem in the code and the fix seem obvious. Signed-off-by: Nick Clemens <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
