https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #13 from Nick Clemens <[email protected]> ---
(In reply to Marcel de Rooy from comment #10)
>         if( $issue ){
>             my $date_due_dt = dt_from_string( $issue->date_due, 'sql' );
>             $duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M');
>             $input{borrowernumber} = $issue->borrowernumber;
>             $riborrowernumber{0}   = $borrower->{'borrowernumber'};
>         }
>         $input{duedate}   = $duedate;
>         $input{not_returned}   = 1;
> 
> 
> This raises questions. If no issue, you set not_returned? Shouldnt it depend
> on issue?

No issue is one reason for not_returned, others are withdrawn blocked, lost
blocked etc. So the issue variable may or not be present, but the elsif block
we are in means the item was not returned.

> 
> And some untidiness:
>  WARN   circ/returns.pl
>    WARN   tidiness
>                 The file is less tidy than before (bad/messy lines before:
> 230, now: 236)

Tidied

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to