https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374
--- Comment #24 from Pedro Amorim <[email protected]> --- Hey, adding my opinion here. This should be 2 different bugs, one specifically as a bookings modal follow-up tidy and restructuring, and the other bug for the keep JS files tidy stuff. The former should be good to go but the latter may be worth discussing further. I like the idea behind the *keep tidy* but I worry that having to specify each file manually going forward will not work in the long term, i.e. another thing to maintain/consider, will get forgotten, etc. Personally I'd prefer we do it on a by directory basis, as Martin's originally suggested but perhaps at a lower i.e. koha-tmpl/intranet-tmpl/prog/js/modals/ instead of koha-tmpl/intranet-tmpl/prog/js/modals/place_booking. This could cause conflicts for other work sitting in bugzilla for starters but could also be seen as a middle ground between specifying each file individually and tidying the whole code base at once. Either that or make sure newly created .js files have the *keep tidy* at the top. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
