https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893
--- Comment #30 from Katrin Fischer <[email protected]> --- (In reply to Marcel de Rooy from comment #25) > (In reply to Katrin Fischer from comment #24) > > > 1) It looks like cancel is not actually checking for the status of an order > > line. Should we be able to cancel an already cancelled order, add a "not > > cancelled" to our search or do I miss something? > > > > + my @result = Koha::Acquisition::Orders->search( { biblionumber => > > $biblionumber } )->cancel; > > Out of scope a bit? This plural cancel is just a wrapper around the singular > cancel which did not check that before. The good news is that it actually > does not really matter. It can be run again. Note the new check on not > overwriting the cancellation date that I added recently. I didn't expect you to fix cancel, just wondered if there should be another parameter to limit by status. - but reassured by your comment that the cancellation date would not be changed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
