https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #32 from Katrin Fischer <[email protected]> ---
This patch set contains some small issues I have fixed in a follow-up. Please
keep in mind for later submissions :)

This string in JavaScript is not translatable. _() must be used:

+            var content = "<h3>Authority #: [% authid | html %]</h3><hr>";

Also capitalization should be "MARC preview" according to our guidelines here:

+                            <a class="btn btn-default" id="preview"
href="#"><i class="fa fa-eye"></i> MARC Preview</a>

One general question: With this we have a different style of preview from the
result list of the authortiy search and the detail page. Should they be
labelled differently? Should they be styled the same?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to