https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919
--- Comment #72 from Tomás Cohen Arazi <[email protected]> --- (In reply to Katrin Fischer from comment #70) > 1) Page title > > We since changed the markup there for better translatability among other > things. Please adapt: > > +<title> > + Record sources › Koha > +</title> Fixed. It would be great if it was documented somewhere or there was something in the guidelines about this. I copied what's done in the other Vue apps as requested by QA, and they don't implement this currently. Done anyway. > 2) Missing permissions.inc > > Guess everyone has only been testing as a superlibrarian again? ;) > > Wanted to fix in a follow-up, but got stuck on 5) :( Fixed. > 3) Reconsider sequence on admin page > > Currently this shows as the last entry below the Elasticsearch config, but I > feel it would be better suited with the matching/overlay rules, what do you > think? I agree. Done. > 4) Missing from side navigation > > The left hand admin navigation panel was missed. Sequence should match admin > page, so good to do 3) first :) Right, good catch. Done. Preserving the order discussed above. > 5) Apache config? > > When trying to access the admin/record_sources I have a 404 error. > > I tried yarn build, restart_all and reset_all. I'm not sure what's going on on your KTD, but I was playing with 'main' and just: ```shell git bz apply 35919 ktd --shell reset-all ``` and the record sources page is there. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
