https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746
--- Comment #32 from Brendan Lawlor <[email protected]> --- (In reply to Lucas Gass from comment #28) > This changes the :all option into from a single select dropdown to a multi > one. I don't think that is necessarily bad, could be handy actually! Good catch Lucas! I think that this should not happen because it would change how current reports work. There could be cases where you only want a parameter to be single choice or the all option but not multi select. The original patch relied on the value of the template variable always being put in the html tag as either the attribute 'multiple' or as an empty string for single selects. My understanding is that causes a problem with translations. I changed one conditional so that only selects that should be multi will get the multiple attribute and it doesn't have invalid TT inside the select tag so it passes the test too. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
