https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134

--- Comment #8 from Pedro Amorim <[email protected]> ---
(In reply to Lucas Gass from comment #7)
> (In reply to Pedro Amorim from comment #6)
> > Hey guys, looking here. My goal is to contribute (not block) so if the
> > following doesn't make sense or you disagree, please ignore.
> > 
> > I'm not a fan of the proposed solution because it's changing arbitrary
> > values for different arbitrary values (although relative to the screen) ->
> > it does not look like a definitive fix. Having said that, I understand it
> > and I believe the reason behind is that window popups are a bit of a wild
> > west, in my opinion (see bug 36143).
> > 
> > As an alternative proof of concept, I'm proposing we use a default window
> > size but also save whatever resize the user applies to the pop-up and use
> > that going forward. This way, ideally, any user can resize to whatever size
> > feels comfortable to them and when they open the popup again it'll open the
> > window using those size values instead.
> > 
> > My suggestion is not meant to be the end all be all for window pop ups, but
> > rather to stimulate discussion and brainstorming around this.
> 
> I'm for this idea. I didn't test because your alternative patch doesn't seem
> to apply.

Sorry, was built on top of yours. It should perhaps have been it's own
standalone thing but wanted to keep your patch as the default initial size, and
extend it. Try applying both, it should work.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to