https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546

David Cook <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from David Cook <[email protected]> ---
I am so happy to see other people talking about this, because this has been
driving me crazy for *years*. It's arguably my biggest pet peeve about Koha!

A few years ago, I got Jan Henning Thorsen to add
"skip_validating_specification" to Mojolicious::Plugin::OpenAPI, and I've
turned that on locally in Koha, but it hasn't made a noticeable difference to
startup times, and when I use strace I notice something similar to Didier. The
same syscalls over and over again:

newfstatat(AT_FDCWD, "/usr", {st_mode=S_IFDIR|0755, st_size=4096, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share", {st_mode=S_IFDIR|0755, st_size=4096, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha", {st_mode=S_IFDIR|0755, st_size=4096,
...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger", {st_mode=S_IFDIR|0755,
st_size=4096, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
{st_mode=S_IFREG|0644, st_size=44125, ...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/usr/share/koha/api/v1/swagger/swagger.yaml",
{st_mode=S_IFREG|0644, st_size=44125, ...}, 0) = 0

Jan was always skeptical about the validation being the problem, but he
humoured me nonetheless. In my tests in 2021, skipping validation solved the
problem, but using "skip_validating_specification" hasn't helped in 2024 (and
earlier years).

Even back then, I figured the problem was with the dereferencing of the spec,
but it seemed to only happen with the validation. 

I'd be interested to see a flamegraph generated with Tomas's patch. I'm going
to give it a go now and see what strace says...

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to