https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #61 from Victor Grousset/tuxayo <[email protected]> --- > * Column names look old-school IMHO (`id`vs `oai_server_id`) That's a definitely an issue: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL7:_Primary_keys «primary key name must be tablename_id (color_id for example) » Also it seems for new columns we are now using snake_case: https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file «Example 2: Adding a new column» Except for foreign keys like biblionumber > * Why is the `oaiservers` table name used instead of `oai_servers`? (same for > oaiservers.{ps|tt}) +1 for consistency with how new stuff is usually named. --- Code: > sub ServerSearch This rule should also apply on new all new files outside C4: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL9:_Subroutine_naming_conventions «subroutines in the Koha namespace should be snake case» --- String changes: #: installer/data/mysql/en/mandatory/sample_notices.yml:letter:1:row:98:mul:4 msgid "Set: %s" #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oaiservers.tt:92 msgid "Set: " +#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oaiservers.tt:136 +#, fuzzy, c-format +msgid "Set" They need context for translators: https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC#More_on_context And using tp() is an opportunity to deduplicate "Set: " and "Set" +#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oaiservers.tt:126 +#, c-format +msgid "%s You searched for record %s %s You searched for %s %s " This string should be split. Either via t() or <span> --- I reattached the patches to fix the order that broke applying. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
