https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Victor Grousset/tuxayo <[email protected]> --- Partial QA (not sure enough on the functional side): Magic number here for the permission flag: > my $librarian = $builder->build_object( > { > class => 'Koha::Patrons', > value => { flags => 2**13 } > } > ); --- https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.2:_required > SWAGGER1.3.2: required > All resources should have a list of required fields specified Is it just that nullable fields should be defined with "null" in the type list? If so, it's ok. --- That's quite sus ↓↓↓↓↓ ↓↓↓↓↓ > # Filtering works, two agreements sharing vendor_id > $t->get_ok( "//$userid:$password@/api/v1/additional_fields?tablename=" . > $additional_field->tablename ) > ->status_is(200)->json_is( [ $additional_field->to_api, > $another_additional_field->to_api ] ); --- It seems the `503:` section isn't necessary. After putting Koha in maintenance mode: `UPDATE systempreferences SET value = 1 WHERE variable = "version";` And removing the section and restarting. I still get the expected {"error":"System is under maintenance."} and the response 503 code. Sabotage confirmed that if I break that file and restart, it's taken into account. So it's not that my removal wasn't taken into account. Same with `500: ` section. I put a `die;` in Koha/REST/V1/AdditionalFields.pm#list And I still get {"errors":[{"message":"Internal Server Error.","path":"\/"}],"status":500} Looks like the same for 400 and 403, tests still pass after removing them. All these are in many other API routes. Maybe they are useful or maybe we have been adding dead API code for a while. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
