https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620
--- Comment #14 from David Cook <[email protected]> --- Firstly, thanks for working on this. It hasn't been a priority for me, so it's cool to see someone else take up the thread. Secondly, I'm not sure if you're still working on this, but if you are ready to submit, I'd have to mark this as "Failed QA". 1. You'll need to add the syspref to ./installer/data/mysql/mandatory/sysprefs.sql as well 2. You'll want to use camel case instead of snake case. While there are about 7 snake case there are 827 camel case sysprefs. 3. I'd suggest using HttpForwardProxy as the system preference name just to be as explicit as possible 4. I think that we'd only want to show the "Do not use proxy" on z3950servers.tt *if* HttpForwardProxy is defined. Otherwise, it's going to be meaningless/confusing for 99.99% of users 5. Instead of "not_proxy" we might want to say "do_not_use_proxy" or "no_foward_proxy". They're more verbose, but they're also more descriptive. 6. In Breeding.pm, technically I don't think you'd want to use the "g" option, and you should preface "http" with a ^ so that it matches the start of the string. Your regex would probably be fine in the majority of cases, but I think it wouldn't hurt to be more specific. -- Otherwise I think all good -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
