https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610
Shi Yao Wang <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #39 from Shi Yao Wang <[email protected]> --- (In reply to Pedro Amorim from comment #33) > Failing QA here: > > - Missing tests > - import_borrowers.tt should check if a given patron_attribute that's being > added is is_date and validate the data accordingly, else the following bug > may occur: > > 1) Create a patron attribute type of is_date as per the original test plan, > named 'date' > 2) Import a patron, visit: > /cgi-bin/koha/tools/import_borrowers.pl > 3) Click "Download a Starter CSV file with all the columns." and add a > cardnumber, categorycode, branchcode and on the patron_attributes column put > date:test > 4) Import, notice the import is successful, now visit that patron edit page > (do a search for the imported cardnumber), e.g. example for patron id 289: > /cgi-bin/koha/members/moremember.pl?borrowernumber=289 > 5) Notice it blows up with error: > Template process failed: undef error - The given date (teste) does not match > the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205. > at /kohadevbox/koha/C4/Templates.pm line 127 - Added some tests - Added error handling for date type patron attribute. Borrower import should now skip patrons with invalid value of date type patron attribute. (In reply to Pedro Amorim from comment #34) > Not a blocker, but why the design decision of restricting a date attribute > type to not be able to also be repeatable? > > I can't find many good examples of how a repeatable date field would be > useful, but I don't understand why we wouldn't allow it either. It should be repeatable now Putting to Needs Signoff for someone to test repeatable date attribute. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
