https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | CC| |[email protected] Status|Signed Off |Failed QA --- Comment #6 from Victor Grousset/tuxayo <[email protected]> --- The first attempt, the selected text in a subfield has a 1 second latency before highlighting text selected. (auth and biblios so it's from Bug 35383) That's weird but not blocking. (In reply to Andrii Nugged from comment #3) > Note: there was related issue: Bug 35383, solved differently, but I think we > should analyze how to make "common", unified solution with same coding style Good point, I had issues testing and when it worked, I forgot about this and attached a second signoff (it's just a 2nd signoff, it's valid). Back to this remark, for QA that's an issue because copying the change of bug 35425 is introducing duplication. initializeSortable() is totally duplicated and even the calls to it would benefit from being in the same place for biblios and auths to be sure that if those for on editor are changed, the others are. cataloging.js is included in addbiblio.tt and authorities.tt so unless something unexpected, moving the js change from addbiblio.tt and authorities.tt to cataloging.js should work. And then it's possible to solve the duplication of when cloning a field in cataloging.js. Because that part has the same code as initializeSortable() I don't know if it was noticed in bug 35425 that duplication was introduced, but it was it might have been ok to not bother. But now it's a third time duplication, see rule of three: https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
