https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

--- Comment #16 from Marcel de Rooy <[email protected]> ---
(In reply to Katrin Fischer from comment #15)
> I have to admit that we have used this column in migrations to allow for
> reporting. And I feel we are not the only ones. Right now we just drop the
> column without checking for any contents.

Did you really? :)

> Could there be a more clever way of doing this, that raises a warning first?

Well, will add a follow-up to meet your request. But have to admit that I was a
bit hesitant to do so. You could theoretically say that people filling Koha
columns with their own data should not depend on the development team to
recover that data.

> In light of us wanting to do more clean-up I think it would be worth to
> agree on how to handle this in general and then apply it to every removal
> moving forward.

I do not hope that this argument will hijack this simple cleanup operation.
Please start that discussion elsewhere.

> Maybe something like we did for items.paidfor?

I chose another approach.

> Database update is missing the "success" say out line.

I have never seen that as a requirement. Which coding guideline is that?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to