https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753

--- Comment #26 from Martin Renvoize <[email protected]> ---
Comment on attachment 163479
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163479
Bug 27753: Added new system preferences for automatically resolving claims

Review of attachment 163479:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27753&attachment=163479)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +2531,5 @@
>  
>      if ( C4::Context->preference('ClaimReturnedLostValue') ) {
> +        my $autoClaimReturnCheckin = 
> C4::Context->preference('AutoClaimReturnStatusOnCheckin');
> +
> +        if ($autoClaimReturnCheckin) {

I think the placement of this statement is wrong.. now it all relies on there
being an autoClaimReturnedCheckin status set..

I think we need to move the check for ReturnClaims up outside of this block and
trigger the autoResolve or not based on this check only (and the differing
return of course)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to