https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from David Nind <[email protected]> ---
I had a go at re-testing, but I found things a little confusing and then had
some errors (step 19).

The tests passed before and after the patches.

Testing notes (so far), using KTD:

- Step 4: When I cancel the hold, there is a message saying "Please retain this
item and check it in to process the hold." for Patron B.

- Steps 6, 4, and 5; then there is step 6 again - I'm assuming these can be
ignored. For example the SQL in the first step 6 says "Patron A's
borrowernumber", however there is only one row in the table and that is the
hold for Patron B.

- Step 11:
  . For the Holds section of the bibliographic record it shows as an item level
hold, as per the test plan
  . On the normal view: "In transit from Centerville to Midway since 04/30/2024
There is an item level hold on this item (priority = 1)."
  . If I change the library to Midway, Circulation > Transfers > Transfers to
receive shows the transfer
  . I cancelled the transfer and deleted the hold

- Step 15:
  . No new modal popped up after selecting a cancellation reason the cancel
hold
  . Normal view status: There is an item level hold on this item (priority =
1).
  . Holds section details: Only item XXXXX
  . Patron details: not showing as waiting for pickup
  . Circulation > Holds awaiting pickup: no holds showing

- Step 19: repeat steps 1-6 - for step 2, I get this error:

Can't locate object method "damaged" via package "32" (perhaps you forgot to
load "32"?) at /kohadevbox/koha/C4/Reserves.pm line 858
in C4::Reserves::CheckReserves at /kohadevbox/koha/C4/Reserves.pm line 858
  855: 
  856:     return unless $item; # bail if we got nothing.
  857: 
  858:     return if ( $item->damaged &&
!C4::Context->preference('AllowHoldsOnDamagedItems') );
  859: 
  860:     # if item is not for loan it cannot be reserved either.....
  861:     # except where items.notforloan < 0 :  This indicates the item is
holdable.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to