https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753
--- Comment #42 from Laura Escamilla <[email protected]> --- (In reply to Martin Renvoize from comment #41) > OK.. I'm happy to tidy up here and get this over the line.. however, I have > some questions. > > 1) In AddReturn, was it deliberate to use 'patron from last checkout' as the > 'resolved_by'.. or should that be the librarian performing the return > action? (Remember in both cases this could be undefined.. if we use > 'librarian' then we can get that from the userenv of the session.. this > "should" always be set these days.. if we are using the patron then the > checkout may have already been marked at completed in which case the > relation accessor will fail and you won't have a patron and the call to > resolve will fail. ---Ack. For logging purposes I believe it would be useful to use the 'librarian'. > > 2) Should we be handling the lost_item_status in any way? In the > interactive approach we give the librarian the option to set a new lost item > status (and the resolve method accepts said status if passed).. should we be > setting that here too.. or is that perhaps another bug? --- Let's file a follow-up bug for this. > > 3) Checkout functionality suffers from the same questions as above? > > 4) I tend to like subtests to be a little more self-contained with a > database transaction and rollback rather than relying on other test data > defined earlier in the test.. I stuck to how you started the tests here but > as a future point it may be a good practice if you can to make them more > isolated. --- Thank you for the feedback on unit tests! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
