https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503
--- Comment #32 from Martin Renvoize <[email protected]> --- (In reply to Clemens Tubach from comment #30) > (In reply to Martin Renvoize from comment #26) > > Created attachment 166115 [details] [review] [review] > > Bug 36503: (follow-up) Simplify code by passing by reference > > Hi Martin, > thanks for your work and your time! > Unfortunately this patch does not work for our plugin. > Our plugin sets the patron if it is undefined: > > if ( !$args->{'patron'} ) { > # Find the patron by card number. > my $patrons = Koha::Patrons->search( { 'cardnumber' => $cardnumber } ); > if ( $patrons->count == 1 ) { > $args->{'patron'} = $patrons->next; > $logger->warn('Patron found.'); > } > } > > So, with your patch, $patron is still undefined after calling the hook. That should still work find.. have you tested? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
