https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972
Emily Lamancusa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #34 from Emily Lamancusa <[email protected]> --- (In reply to Marcel de Rooy from comment #33) > QA Comment: > > [1] Last question? > - C4::Items::ModItemTransfer( > - $itemnumber, > - $item->holdingbranch, > - $checkreserves->{'branchcode'}, > + ModItemTransfer( $itemnumber, $userenv_branch, $diffBranchSend, > 'Reserve' ); > Are we sure that this new transfer should be from $userenv_branch in all > cases ? (Noting that the check already referred to userenv_branch before > this change.) > > The second call looks like: > + ModItemTransfer( $itemnumber, $item->holdingbranch, > $reserve->{branchcode}, 'Reserve' ); > And that just convinces me more (at least, at first glance)? But the other > way around: why not userenv_branch here, since that is the branch where we > are checking in now? They should be equal here since we called AddReturn > already. So second call is fine. As you say, in the second case they should be equal since it's explicitly called after AddReturn. In practice, the first case is always called after AddReturn as well, since we only reach that step after the user has responded to a modal. But that is neither obvious from the code nor strictly enforced, so I used $userenv_branch to be safe (and to be consistent with the immediately preceeding code). Presumably, the item is in the hand of the staff member performing the return, so transferring from the staff member's current location makes sense. I can't think of any situations where we shouldn't make that assumption in returns.pl. Totally agree about ModReserveCancelAll. It and ModReserveMinusPriority should both be in line for removal, really... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
