https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164
--- Comment #5 from Jonathan Druart <[email protected]> --- I like it. Some things: * There is margin 1rem 0 from .toptabs that makes #sub-header no longer sticking #header_search https://snipboard.io/7XhEir.jpg vs https://snipboard.io/csJ5CR.jpg * + [%# FIXME: Confirm messages.inc is needed. Neither circulation-home and cataloging-home use output_and_exit from C4::Output#%] We want messages.inc EVERYWHERE. It has the "wrong csrf-token" error, and ideally we will use it for all our dialog messages/errors. * Bad news, we cannot split TT directives on several lines (see bug 18675). * I would move the BLOCKs from html_helpers.inc to a separate include file (html_helpers/landing_page.inc?) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
