https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

--- Comment #18 from Katrin Fischer <[email protected]> ---
I checked in our production systems with acq and the booksellerid is always set
to the vendor id. So this should work:

1) Create a new basket, make sure you set item creation to "on order"
2) Create an order line with one or more items
3) Close the basket
4) Receive shipment for that vendor
5) Receive your order line with the item
6) Check the item - some fields should have been set by the acq module, like
price and booksellerid.

I feel the feature as suggested is not useful and might be confusing to a lot
of libraries even. I made a suggestion on how to resolve to vendor name in
comment#3, it's the same code used on the items tab (moredetails.pl), so it
would give us consistency to use the same logic.

I was hoping to spot the logic in a proper module, but... *sigh*

https://git.bsz-bw.de/koha/koha/-/blob/master/acqui/finishreceive.pl#L181

my $new_order_object = Koha::Acquisition::Orders->find( $new_ordernumber ); 

# FIXME we should not need to refetch it
my $items = $new_order_object->items;
while ( my $item = $items->next )  {
    $item->update({
        booksellerid => $booksellerid,
        dateaccessioned => $datereceived,
        datelastseen => $datereceived,
        price => $unitprice,
        replacementprice => $replacementprice,
        replacementpricedate => $datereceived,
    });
}

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to