https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735
--- Comment #6 from Emily Lamancusa <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #5) Thanks for the feedback! > Correct, they should all be html filters now. In the end we are building a > form and submitting, so they won't be in a URL In retrospect this was a dumb question. ^^" Fixing... > I think I understand the issue, it seems odd to have the JS asset in the > script and not in the include directly? In this case, the include is only > used on this page, but perhaps adding a comment to the include to specify > that it needs the asset would be helpful? Basically, yes. Thanks, just wanted another pair of eyes in case there was a better solution that I wasn't finding. Keeping this as signed-off and attaching a follow-up since both of the above are trivial changes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
