https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Nick Clemens (kidclamp) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[email protected]

--- Comment #31 from Nick Clemens (kidclamp) <[email protected]> ---
I like this a lot - self contained and makes minimal changes, the patches are
clean and easy to read, but I think we need to consider some things here before
this moves ahead

Must fix:
The JS alerts to prevent submission fire an alert per warning, so you need to
click through several if you make a mistake - these should be combined into a
single alert

There is no way to see the limits you have placed on your search - I think
these need to be shown to the user, ideally they would be editable, but showing
them would be a start

Should fix:
While I like the idea of minimalizing data for privacy, excluding the borrower
info on the holds feels a bit too far. Ideally this would be under columns
configuration, and we have patron-title.inc for showing borrower info only to
staff who should see it. The current column selection feels 

The display should be paginated, ideally it would use the holds API to load the
holds to ensure performance, as scrolling can get really long really fast. It
would be nice too to be able to select all in a filtered search - right now
'Select all' selects even those not visible in the table

Could fix:
If implemented with the datatables API this could then work like the patron
search, with filters present on the page. 

The batch edit implies more batch actions - cancellation, reverting, etc. but
these can all be follow-ups I think

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to