https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #59 from Katrin Fischer <[email protected]> --- As a non-native speaker, I have a giant pet-peeve: Translatability. 1) Translatability (please follow-up) a) It looks like you are building somewhat nice error messages in ImportKBARTFile.pm, but this is the wrong spot. Example: + my $formatted_title = format_title($new_title); + if ( !$formatted_title->{publication_title} ) { + push @messages, { + code => 'title_failed', + type => 'error', + error_message => "No publication_title found for title_id: ", + title => '(Unknown)', + title_id => $formatted_title->{external_id} + }; I think these should be codes and then resolved in the template to make them translatable in the templates. b) I believe these are also not translatable in .vue files? + <li>Column headings row</li> + <li>Title data row</li> We have this construct just a few lines above: <li>{{ $__("The file must be in TSV or CSV format") }}</li> c) Do not include the HTML in the translatable string. Use concatenation. These are likely to get broken in process or by translators getting confused: + message += this.$__( + "<p style='font-weight: normal; font-size: medium; margin-top: 1em;'>Your file was too large to process in one job, the file has been split into %s jobs to meet the maximum size limits.</p>" + '<li>Job %s for uploaded file has been queued, <a href="/cgi-bin/koha/admin/background_jobs.pl?op=view&id=%s" target="_blank">click here</a> to check its progress.</li> (some more of these in the file below) 2) File endings (separate bug/future) Most of the time KBART files are received as .txt. It looks like the code expects the "correct" file endings .csv and .tsv. This can be a problem for libraries especially if they are working in Windows and file endings are set to not show. Some might not have the choice to change that easily. It would be great if we could do some kind of auto-detection for .txt files. (maybe checking for the tab chars?) 3) Accessibility (follow-up) Accessibility guidelines say we should not use constructs like "click here" - a link should already be clear by it's formatting. And we should always make sure to have a good link text that has "sense". + <a href="/cgi-bin/koha/erm/eholdings/local/packages/[% report.package_id | $raw %]">Click here to see the package</a> Why not just "Package"? 4) Terminology (done) We are trying hard to get rid of "biblio" which is not a real word :) (see wiki/terminology list). + >{{ $__("Create linked biblio record") }}:</label I'll fix that one in a follow-up (bibliographic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
