https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978

Tomás Cohen Arazi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Tomás Cohen Arazi <[email protected]> ---
Hi, I attached a patch making this look what I believe it should.

I'm failing it until we have the tests fixed by the authors.

Notes:

* The patchset introduces 'warn' calls on a package, which are not covered by
tests. This should not be the case
* We might need to revisit if `warn` plus `return` is the right thing to do
here. I'm tempted to suggest it should just be an exception properly handled on
the `install_plugins.pl` script.
* My follow-up adds an exception for explicitly forbidding both `include` and
`exclude` being used simultaneously. This... needs a test as well!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to