https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
Emily Lamancusa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #33 from Emily Lamancusa <[email protected]> --- Taking a look at this one... It looks like there are some test failures: t/db_dependent/Koha/Account/Line.t .. 1/15 # Looks like you planned 4 tests but ran 2. # Failed test 'library() tests' # at t/db_dependent/Koha/Account/Line.t line 173. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.old_issue_id' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 95 # Looks like your test exited with 255 just after 4. t/db_dependent/Koha/Account/Line.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 12/15 subtests t/db_dependent/Circulation.t .. 17/74 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1753. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.old_issue_id' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 319 # Looks like your test exited with 11 just after 17. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 58/74 subtests I'm also not sure it makes sense to put all steps of the dbrev inside the "unless" that checks for the existence of the old_issue_id column. If for some reason the column exists but the foreign keys don't exist (e.g. a previous update failed in the middle), the whole dbrev would be skipped and the foreign keys wouldn't be created. I think it should be pretty doable to have a separate check for most individual steps of the dbrev. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
