https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771
--- Comment #3 from Katariina Pohto <[email protected]> --- Created attachment 166780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166780&action=edit Bug 35771: Unselecting titles when making multi-hold does not have any effect This patch moves the holdable_bibs id and value to the checkmark input. It doesn't do the same for the club multihold (which probably should be added), and doesn't change the <input name="biblionumber"> field which lists the biblios that end up on the URL query. It might also be beneficial to change the placerequest.pl's redirect to request.pl to use the holdable_bibs list instead of the biblionumber list, so the unselected biblio wouldn't appear on request.pl page after the holds are placed Test plan: 1. Select several biblios and choose Place hold 2. Choose a patron 3. Select a pickup location for all biblios and unselect one of the checkmarks 4. Place holds and note that even the deselected holds was placed. 5. Repeat steps 1-2. 6. Leave pickup locations empty and try to place the holds. 7. Note alert: "Please make sure all selected titles have a pickup location set" 8. Uncheck one of the biblios and add pickup locations to the checked biblios. 9. Try to place the holds and note that there is no alert, and you get an error 500. 10. Apply patch. 11. Repeat steps 1,2,8 and place holds. 12. Note that there is no error 500, and while all the biblios are shown on page, only the checked biblios have a new hold placed on them. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
