https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872
Caroline Cyr La Rose <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166826|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <[email protected]> --- Created attachment 166827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166827&action=edit Bug 36872: Untranslatable strings in request.tt There are errors in the JavaScript in the holds template in the staff client which results in strings not being translatable. This patch corrects the errors. To test, apply the patch and run through the process of placing a hold on multiple items in the staff interface. - At the hold confirmation step, try to submit the form without selecting pickup locations for one or more titles. - You should get an alert, "Please make sure all selected titles have a pickup location set". - Uncheck the checkboxes next to each title you're placing a hold on. - Submit the form. You should get an error: "Please select at least one title". - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 - You should see the string "Please make sure all selected titles have a pickup location set". Signed-off-by: Caroline Cyr La Rose <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
