https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36880

David Nind <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
           Assignee|[email protected] |[email protected]
                   |ity.org                     |
                 CC|                            |[email protected]

--- Comment #2 from David Nind <[email protected]> ---
Failing QA, because if you edit an existing rule, you can remove the value in
the tag field and still save (when you click on save, the tag input field is
briefly red, but it still saves without a value).

I also added Jan as the assignee.

Testing notes (using KTD):

1. Go to: Administration > Catalog > Record overlay rules
2. Before the patch, if you click '+Add rule' a single rule is added, even if
no value is entered in the tag field. Clicking on '+Add rule' after this
results in table refreshing, but no new rule added.
3. After the patch, the tag field is highlighted in a dark red and a rule isn't
added until a value is entered.

I haven't noticed this pattern elsewhere in Koha, maybe there needs to be a
separate bug for colour contrast as the black text on the dark red background
for the input field could be hard to read for some.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to