https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916

--- Comment #1 from Jonathan Druart <[email protected]> ---
Created attachment 167011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167011&action=edit
Bug 36916: Do not generate invalid JS or CSS from TestBuilder

TestBuilder generates random strings for branches.opacuserjs and
branches.opacusercss which produces invalid JS and CSS.

Selenium has several warnings related to this:

koha-selenium-1   | JavaScript error:
http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError:
CLYxPjQ152 is not defined
koha-selenium-1   | JavaScript error:
http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError:
CLYxPjQ152 is not defined
koha-selenium-1   | JavaScript error:
http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError:
CLYxPjQ152 is not defined

Because of the following in the DOM
    <script>
        CLYxPjQ152
    </script>

This patch suggests to set to an empty string by default, to prevent random
failure or inconsistent behaviours when testing the UI.

Test plan:
Run t/db_dependent/selenium/authentication.t and watch the selenium
output.
With this patch applied you will not see the "JavaScript error" lines

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to