https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924
--- Comment #9 from Marcel de Rooy <[email protected]> --- (In reply to Jonathan Druart from comment #7) > (In reply to Marcel de Rooy from comment #6) > > Created attachment 167041 [details] [review] [review] > > Bug 36924: (follow-up) Remove unused $transfer > > > > Signed-off-by: Marcel de Rooy <[email protected]> > > This is what I've tried first but actually I'm my understanding we are > removing the test. We want to make sure it is still working if a transfer > exists. We load the records in a mocked Zebra, but they do not exist in db. Now we are adding a transfer to an item that is not there. Scrolling thru C4/Search, I am wondering if we do not have other calls that miss a referenced record too (biblio or item etc). So if you want to really fix this, you will need to add some items and manipulate the marcresults that you pass to searchResults and update those itemnumbers. I think that the test in its current form has very limited value (in view of the mocks and bad data). Fixing that is kind of advanced hacking. I opt for removing it. Will remove my follow-up for now. We should certainly not update TestBuilder for this! We could hide the warning but it is useless imo. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
