https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
--- Comment #69 from Matthias Meusburger <[email protected]> --- Thanks for your feedback, Tomas and Victor! Tomas: * Why is the `oaiservers` table name used instead of `oai_servers`? (same for oaiservers.{ps|tt}) * Why we sometimes call it `oai` and sometimes `oaipmh`? * OaiServer should either be OAI::Server or OAIServer. * Column names look old-school IMHO (`id`vs `oai_server_id`) => Done * Can we pick names that match biblio_metadata columns for example? Like `format` and `schema` instead of `recordtype` => I'm not sure I understand what you mean by that. In this situation, recordtype is here to tell if the record is a biblio or an authority, while format and schema are not used for this. Can you elaborate on this? * Is `datestamp` some OAI-PMH specific naming convention? => Yes it is, see https://www.openarchives.org/OAI/openarchivesprotocol.html#SelectiveHarvestingandDatestamps for instance. * `repository` varchar(255) NOT NULL COMMENT 'OAI repository'? Shouldn't this be a FK on the `oaiservers` table? This feels important as we are also adding 'record sources' on another bug, and we will eventually want to set rules for OAI-PMH imported records. => Do you mean a FK from import_oai_biblios/import_oai_authorities.repository to oai_servers.endpoint? * Can the OAI harvester be thought as a background job in the mid/long term? In that case, it feels weird that Koha::OAI::Client::Harvester just prints things. It might be better to -for example- accumulate them using Koha::Object->add_message and have the caller decide what to do? (so harvest_oai.pl decides what to do) or it could just be a callback function for dealing with each step's output. => Done through a callback function. Victor: > sub ServerSearch => Done And using tp() is an opportunity to deduplicate "Set: " and "Set" => Done This string should be split. Either via t() or <span> => Done -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
