https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36820
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |[email protected] --- Comment #4 from David Nind <[email protected]> --- Can confirm David Cook's comment - if status is changed back to pending, an email is sent. Not sure what the correct behavour should be. Tests fail (so have changed to Failed QA): prove t/db_dependent/Koha/Suggestions.t t/db_dependent/Koha/Suggestions.t .. # Failed test 'If EmailPurchaseSuggestions is not enabled, a message should not be sent' # at t/db_dependent/Koha/Suggestions.t line 75. # got: '0' # expected: '1' # Failed test 'NEW_SUGGESTION should not be sent again if status has not changed' # at t/db_dependent/Koha/Suggestions.t line 94. # got: '0' # expected: '1' # Looks like you planned 9 tests but ran 10. # Looks like you failed 2 tests of 10 run. t/db_dependent/Koha/Suggestions.t .. 1/11 # Failed test 'store' # at t/db_dependent/Koha/Suggestions.t line 119. t/db_dependent/Koha/Suggestions.t .. 11/11 # Looks like you failed 1 test of 11. t/db_dependent/Koha/Suggestions.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests Test Summary Report ------------------- t/db_dependent/Koha/Suggestions.t (Wstat: 256 (exited 1) Tests: 11 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=11, 8 wallclock secs ( 0.02 usr 0.01 sys + 4.55 cusr 2.98 csys = 7.56 CPU) Result: FAIL Testing notes (using KTD): 1. For EmailPurchaseSuggestions/EmailAddressForSuggestions set to 'EmailAddressForSuggestions' and add an email address, such as [email protected] 2. Create a suggestion in the staff interface (Acquisitions > Suggestions > + New purchase suggestion) 3. Check that the message queue for a pending notice: 3.1 koha-mysql kohadev 3.2 select * from message_queue; 4. Edit the suggestion and add some text to the notes field, but don't change the status 5. Repeat step 3 - another NEW_SUGGESTION notice is queued. 6. Change the status of the suggestion from Pending to Accepted. 7. Repeat step 3 - the ACCEPTED notice is queued. 8. Change the status of the suggestion from Accepted to Pending. 9. Repeat step 3 - another NEW_SUGGESTION notice is queued. 10. Apply the patch and restart_all. 11. Repeat steps 2-3 (add a new suggestion). ==> Result: a NEW_SUGGESTION notice is queued for the new suggestion 12. Repeat step 4 (edit a suggestion but don't change the status). ==> Result: NO NEW_SUGGESTION notice is queued 13. Repeat step 6 (change status from Pending to Accepted). ==> Result: the ACCEPTED notice is queued. 14. Repeat step 8 (change status from Accepted to Pending) ==> Result: another NEW_SEUGGESTION notice is queued (not sure whether this is the correct behavour or not - see comment#3) 15. Run the tests, these should pass: prove t/db_dependent/Koha/Suggestions.t -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
