https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109

--- Comment #13 from David Cook <[email protected]> ---
Comment on attachment 167415
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167415
Bug 31109: Koha::Util::Misc - utility class with miscellaneous routines

Review of attachment 167415:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31109&attachment=167415)
-----------------------------------------------------------------

::: Koha/Util/Misc.pm
@@ +24,5 @@
> +use parent qw( Exporter );
> +
> +our @EXPORT = qw(
> +    digest
> +);

This is an avoidable export which doesn't follow Koha's coding guidelines. 

https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL14:_Exports

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to